fix: turn on ssl features for rust-s3 in Cargo.toml #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebot
commented
Dec 13, 2023
jessebot
commented
Dec 13, 2023
|
Not sure why docker integrations test is failing 🤔 Happy to help out if you would like me to, but would need some pointers as I'm unfamiliar with these tests. |
|
@jessebot Thanks for the PR, I've checked, it's because the one of the CI requires github secrets for SMTP in |
Co-authored-by: JesseBot <[email protected]>
Co-authored-by: JesseBot <[email protected]>
|
thanks so much @speed2exe ! You really are speedy :) |
Horusiath
pushed a commit
that referenced
this pull request
May 28, 2024
fix: turn on ssl features for rust-s3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns on the necessary features for rust-s3 to allow for s3 endpoints that are secured with TLS (which is still known as SSL in about half the places on the internet 😁). I also ran
cargo update rust-s3.error trying to connect: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed#204I followed the advice here: durch/rust-s3#291 (comment) Here's my test notes: #204 (comment)
I've also left some suggestions below to clean up some old comments.